-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Maplint, UpdatePaths, and add new map lints #6656
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
added
Work in Progress
Will never be finished
Tools
things to torment players with
labels
Jul 8, 2024
Fixes incorrect autodoc comments in maplint
Checked all affected if they would benefit by being set explicitly to south, and all already were south
… path and some path cleanup
harryob
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing looks particularly amiss in the diffs of the maps, python code seems fine. would rather this was merged sooner than later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR updates Maplint and UpdatePaths effectively porting these PRs:
@ANY
functionalityNew lints:
Also of note, this PR requires: #6654 so that line change is also incorporated in this PR. But I expect this to take a while for mapping review so made a separate PR for it alone that I can just resolve the conflict for here.
Explain why it's good for the game
Prevents issues like this where the center turfs were rotated (reset):
Fixes turfs resetting:
turf.mp4
Testing Photographs and Procedure
See https://github.com/cmss13-devs/cmss13/actions/runs/9873200755/job/27264944601#step:7:1187 for an example of the maplint suggestions.
Screenshots & Videos
turf2.mp4
Changelog
🆑 Drathek
maptweak: Removed var edits from open turfs to fix ScrapeAway resetting the turf (e.g. xenos building resin walls) on basically all maps
maptweak: Fixed bad dir var edits on various map
maptweak: Fixed stacked structures on various maps
/:cl: